Source string issues found while translating FluentCommunity 2.8.0 to German

Posting this as a translator rather than a bug hunter: I maintain the German
catalogues for FluentCommunity, FluentCommunity Pro, FluentMessaging and
FluentPlayer (about 5,000 strings), and after updating to 2.8.0 I went through
every new and changed string. A handful of English source strings look
unintentional. All line numbers are from 2.8.0 / Pro 2.8.0.

Happy to send a PR for any of these if that is easier for you.

New in 2.8.0

1. A placeholder key is shipped as its own text

fluent-community/app/Services/AdminTransStrings.php:143

'__FLUENT_CART_DESC__' => __('__FLUENT_CART_DESC__', 'fluent-community'),

The UI shows the literal string __FLUENT_CART_DESC__ where the FluentCart
description used to be.

In 2.7.7 the same block held real text one line further down than the FluentCRM
description: AdminTransStrings.php:107 carried Send targeted onboarding
emails… and :108 carried Monetize your courses and spaces by creating and
selling products directly in your community using FluentCart. In 2.8.0 the
block sits at :141–:145, __FLUENT_CRM_DESC__ still has its sentence at
:142, and __FLUENT_CART_DESC__ at :143 has been replaced by its own key.

The neighbouring keys (__COMMUNITY_ACCESS_LABEL__, __EMAIL_SUB_DESC__,
__FLUENT_CRM_DESC__, __IMPROVE_DESC__, __PERMALINK_CHANGE_DESC__) are all
intact, so this looks like a single lost line rather than a pattern change.

2. Singular where the previous wording had a plural

AdminTransStrings.php:55 — Get Feature Update via email

This was Get Feature Updates via email at AdminTransStrings.php:43 in 2.7.7.
The checkbox subscribes to a stream of updates, so the plural reads better; more
importantly, changing it dropped the existing translation in every language.

3. Hyphen used as a dash

AdminTransStrings.php:130

You are in a grace period, so everything keeps working for now. Updates and
support will end soon - renew your license to keep them.

A hyphen-minus between spaces. An em dash, en dash or semicolon would be
typographically correct, and translators tend to copy whatever the source does.

Older, still present in 2.8.0

4. A missing first letter

fluent-community/app/Hooks/Handlers/CustomizerHander.php:81

'order color of the secondary sections' => __('order color of the secondary sections', 'fluent-community'),

Should be Border color of the secondary sections. The line directly above it
reads Border color of the main sections, and this one is the description for
the Secondary Border Color field, so the intent is unambiguous.

(While in that file: the filename itself is CustomizerHander.php, missing the
l in Handler. Cosmetic, but it makes the file hard to grep for.)

5. A sentence with an orphaned comma, a wrong verb form and a stray word

fluent-community-pro/app/Services/Integrations/FluentCRM/AddBadgeAction.php:71

If you enable this, . The newly created user will get the welcome email send
by WordPress to with the login info & password reset link

Three things at once: the , . after "this", send where sent belongs, and
to with where only with belongs. Suggested:

If you enable this, the newly created user will get the welcome email sent by
WordPress with the login info and password reset link.

6. Subject-verb disagreement, four times

fluent-community-pro/app/Services/Integrations/FluentCRM/ContactAdvancedFilter.php

7. Missing verb

fluent-community/app/Http/Controllers/SettingController.php:314

FluentPlayer is required pro version of FluentCommunity. Please install
FluentCommunity Pro first.

Suggested: FluentPlayer requires the Pro version of FluentCommunity. The
parallel message for FluentMessaging six lines above is already correct.

8. Stray capital and a dangling preposition

AdminTransStrings.php:88 — Please Provide a license key of

Four lines below sits Please provide a license key, correctly cased and
complete. The of suggests a product name is concatenated onto the end at
runtime — see the note on fragments below.

9. Wrong preposition

fluent-community/app/Services/TransStrings.php:569 — Describe about this quiz

Suggested: Describe this quiz.

10. Inconsistent ellipses

TransStrings.php mixes dot counts in otherwise parallel strings:
Loading..... (five), Please wait.... (four), Loading editor. Please wait.... (four), Please wait while we redirect you to the appropriate page..
(two), against the correct three-dot form used everywhere else. Each variant is
a separate catalogue entry that has to be translated separately.

One structural request: please avoid split sentences

Several strings are sentence fragments that get a value concatenated onto them
at runtime:

• Are you sure you want to change the URL of your portal to + URL
  (AdminTransStrings.php:17)
• Please Provide a license key of + product name (AdminTransStrings.php:88)
• The Blazing-Fast ⚡️ Community Solution for + name (AdminTransStrings.php:111)
• license has been and expired at as two separate strings
  (fluent-community-pro/app/Services/PluginManager/FluentLicensing.php:316)

German, and most other languages, cannot always keep the value at the end of
the sentence — word order and case endings depend on what follows. A single
string with a %s placeholder solves this completely:

// instead of two fragments plus concatenation
sprintf(__('Are you sure you want to change the URL of your portal to %s?', 'fluent-community'), $url)

And a thank you

2.8.0 changed Item %d of %d to Item %1$s of %2$s and did the same for
Photo. Positional placeholders are exactly what translators need, because the
order of the two numbers is not the same in every language. More of that,
please — and the new aria-label strings in this release are very welcome too.